Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file browser bug #1374

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fix file browser bug #1374

merged 1 commit into from
Nov 21, 2022

Conversation

mvandenburgh
Copy link
Member

After merging #1311, the "no files found" error message is displayed when the list of files is being fetched. This PR tweaks the list of files so that it is initially null instead of an empty array. null indicates the data hasn't been fetched yet, while an empty array would indicate the fetch occured but there was no files at the given path.

Base automatically changed from efficient-modified-update to master November 21, 2022 17:21
@mvandenburgh mvandenburgh added patch Increment the patch version when merged release Create a release when this pr is merged labels Nov 21, 2022
@mvandenburgh mvandenburgh merged commit 47d4ee2 into master Nov 21, 2022
@mvandenburgh mvandenburgh deleted the file-browser-hotfix branch November 21, 2022 17:33
@dandibot
Copy link
Member

🚀 PR was released in v0.3.2 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants