Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent locking dandisets during zarr upload #1385

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

danlamanna
Copy link
Contributor

Zarr upload steps unintentionally lock the dandiset it's operating on because of a select_related. This could cause unnecessary blocking for parallel processes that want to perform zarr uploads on the same dandiset.

Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@danlamanna danlamanna added patch Increment the patch version when merged release Create a release when this pr is merged labels Nov 30, 2022
@danlamanna danlamanna merged commit ab33229 into master Nov 30, 2022
@danlamanna danlamanna deleted the stop-locking-dandisets branch November 30, 2022 15:34
@dandibot
Copy link
Member

🚀 PR was released in v0.3.5 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants