Move asset publishing to publish service #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
move-asset-publishing-to-service-layer
branch
from
ac1065e
to
2e3df10
Compare
mvandenburgh
force-pushed
the
move-asset-publishing-to-service-layer
branch
2 times, most recently
from
fc7973b
to
ef8ad8a
Compare
mvandenburgh
force-pushed
the
move-asset-publishing-to-service-layer
branch
from
e1604b9
to
d7267be
Compare
Moves asset publishing into a dedicated service layer function within the publish service, instead of a model method.
For some reason, we have a test that tries to publish an already published asset. Due to the new checks added in the publish asset service function, this test now fails.
`publish_asset` asserts that an asset is valid. Since we weren't doing that before, several tests started failing and needed to be updated to only attempt to publish VALID assets
Assets must exist in the DB before being published.
It seems the new call to `asset.refresh_from_db` is causing the blob id to be converted to a `UUID` object.
mvandenburgh
force-pushed
the
move-asset-publishing-to-service-layer
branch
from
d7267be
to
dd68d61
Compare
jjnesbitt
approved these changes
Dec 13, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves asset publishing from a model method into a dedicated service layer function within the publish service.