Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify requests as a prod dependency instead of test #1401

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Specify requests as a prod dependency instead of test #1401

merged 1 commit into from
Dec 12, 2022

Conversation

mvandenburgh
Copy link
Member

requests is used to create DOIs, but is listed as a test dependency in setup.py.

@mvandenburgh
Specify requests as a prod dependency instead of test
060f740 
`requests` is used to create DOIs, not just in tests
@mvandenburgh mvandenburgh added the internal Changes only affect the internal API label Dec 12, 2022
@mvandenburgh mvandenburgh merged commit f0b037a into master Dec 12, 2022
@mvandenburgh mvandenburgh deleted the fix-requests-dependency branch December 12, 2022 17:14
@dandibot
Copy link
Member

🚀 PR was released in v0.3.8 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlamanna danlamanna danlamanna approved these changes

Assignees
No one assigned
Labels
internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvandenburgh @dandibot @danlamanna