Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require rejection reason when rejecting a new user #1443

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Require rejection reason when rejecting a new user #1443

merged 1 commit into from
Jan 23, 2023

Conversation

mvandenburgh
Copy link
Member

Closes #1441

@mvandenburgh
Copy link
Member Author

I noticed we're pulling out query params/POST body parameters manually in these endpoints, and it gets kind of messy sometimes. I opened an issue #1444 to address this.

@mvandenburgh mvandenburgh added patch Increment the patch version when merged release Create a release when this pr is merged labels Jan 23, 2023
@mvandenburgh mvandenburgh merged commit f715ff8 into master Jan 23, 2023
@mvandenburgh mvandenburgh deleted the require-rejection-reason branch January 23, 2023 20:55
@dandibot
Copy link
Member

🚀 PR was released in v0.3.12 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlamanna danlamanna danlamanna approved these changes

@jjnesbitt jjnesbitt Awaiting requested review from jjnesbitt

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make reason mandatory to reject a new user?
3 participants
@mvandenburgh @dandibot @danlamanna