Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DLP UI for asynchronous assets summary #1452

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh mvandenburgh commented Jan 30, 2023

async_asset_summary_ui

Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording change to discuss, plus a followup question about setInterval(). Looks great though!

web/src/components/DLP/OverviewTab.vue Outdated Show resolved Hide resolved
web/src/components/DLP/OverviewTab.vue Show resolved Hide resolved
@mvandenburgh mvandenburgh merged commit d27785d into master Jan 31, 2023
@mvandenburgh mvandenburgh deleted the async-assets-summary-ui branch January 31, 2023 20:25
@dandibot
Copy link
Member

🚀 PR was released in v0.3.14 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants