Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display error message for invalid dandiset URL #1454

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Display error message for invalid dandiset URL #1454

merged 5 commits into from
Feb 21, 2023

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh mvandenburgh commented Jan 30, 2023 •
edited
Loading

Closes #1020 #1470

dlp_error

waxlamp
waxlamp approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall!

I had a couple of wording updates (very minor), and I second Jake's suggestion. If you address those things, this is good to go from me.

web/src/views/DandisetLandingView/DandisetLandingView.vue Outdated Show resolved Hide resolved
web/src/views/DandisetLandingView/DandisetLandingView.vue Show resolved Hide resolved
web/src/views/DandisetLandingView/DandisetLandingView.vue Outdated Show resolved Hide resolved
@mvandenburgh @waxlamp
Clean up wording
e74a1d9 
Co-authored-by: Roni Choudhury <2903332+waxlamp@users.noreply.github.com>
@bendichter bendichter mentioned this pull request Feb 7, 2023
Closed
@mvandenburgh mvandenburgh linked an issue Feb 8, 2023 that may be closed by this pull request
incorrect dandiset id page #1470
Closed
@mvandenburgh mvandenburgh added patch Increment the patch version when merged release Create a release when this pr is merged labels Feb 21, 2023
@mvandenburgh mvandenburgh merged commit 16faefd into master Feb 21, 2023
@mvandenburgh mvandenburgh deleted the dlp-not-found-page branch February 21, 2023 14:13
@dandibot
Copy link
Member

🚀 PR was released in v0.3.17 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waxlamp waxlamp waxlamp approved these changes

@jjnesbitt jjnesbitt jjnesbitt approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect dandiset id page Must not silently ignore incorrect version of a dandiset in URL
4 participants
@mvandenburgh @dandibot @waxlamp @jjnesbitt