Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip computing assets summary for invalid assets #1489

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Skip computing assets summary for invalid assets #1489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions dandiapi/api/services/metadata/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,14 @@ def version_aggregate_assets_summary(version: Version):
if version.version != 'draft':
raise VersionHasBeenPublished()

version.metadata['assetsSummary'] = aggregate_assets_summary(
version.assets.values_list('metadata', flat=True).iterator()
)
try:
version.metadata['assetsSummary'] = aggregate_assets_summary(
version.assets.values_list('metadata', flat=True).iterator()
)
except Exception:
# The assets summary aggregation may fail if any asset metadata is invalid, skip
# updating it if it fails.
logger.info('Error calculating assetsSummary', exc_info=True)

Version.objects.filter(id=version.id, version='draft').update(
modified=timezone.now(), metadata=version.metadata
Expand Down