Remove overly aggressive exception handling #1490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1489
@satra I think I understand what you're getting at and this PR is what I'm hoping satisfies requirements. I'll recap my understanding of these changes and rationale for confirmation/discussion.
We shouldn't be marking assets invalid for what are likely bugs in our dandi-archive/dandi-schema software. Instead, an exception will be unhandled and thus tracked in Sentry. The asset will be unable to be validated until we intervene to fix the bug. Since we've been masking this error and storing the results, we can say that all ValueErrors that have been caught to date are of the form
Metadata version x.y.z is not allowed. Allowed are: x.y.z, ...
. (Maybe this is related to people uploading with older versions of cli dandi-cli#935).This could also hide genuine bugs. These are currently logged but not alerted, which is problematic. Historically this has resulted in masking this error:
Does this sound right? And if so, is the idea to merge a PR like this and then address #1450?