Pin to Node 16 in CI #1496
Merged
Pin to Node 16 in CI #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
pin-node-17-in-ci
branch
from
a97560b
to
5711126
Compare
danlamanna
approved these changes
Feb 21, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently failing due to the
setup-nodeaction now defaulting to Node 18. Ideally we would use node 18, but 18 isn't compatible with vue-cli 4. I tried updating to vue-cli 5, but that also implicitly bumps webpack from v4 to v5, which one of our dependencies has some compatibility issues with. We're presumably going to upgrade to Vue 3 relatively soon, at which point this will all be moot because we'll be using Vite instead of vue-cli/webpack. So, for now I've just pinned our node version to 16.