-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back md5 to zarr object url signing #1497
Conversation
The MD5 parameter needs to be part of the original signed URL, otherwise S3 will reject the upload URL. This means the MD5 header used by the client is mandatory.
@jwodder This will require another update from the CLI |
Will the CLI still need to supply a |
Yes, that's what allows S3 to refuse it at time of upload if it's incorrect. |
PR to CLI: dandi/dandi-cli#1215 |
Merging this side of things first. Please hold off merging the other side until I confirm this is working. |
I tried to use my CLI PR to upload to staging, but it failed with a 403 and the message "The request signature we calculated does not match the signature you provided. Check your key and signing method." |
Yeah, sorry about this. We're in an unfortunate situation where our local object store behaves differently than S3 in this specific case, so we're developing a bit blind. I'll update when I figure out what's going on. |
🚀 PR was released in |
Related #1494
The MD5 parameter needs to be part of the original signed URL, otherwise S3 will reject the upload URL. This means the MD5 header used by the client is mandatory.
The CLI will need to update the
/files
step to take a[{path: foo, md5: bar}, ...]
structure instead of a plain list of paths.