Fix max length for name/description on Create Dandiset page #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the max lengths for the name and description on the create dandiset form by pulling them directly from the schema instead of hardcoding.
jjnesbitt
approved these changes
Feb 24, 2023
|
My only concern here is if the schema is guaranteed to be present when this dialog is opened, but the licenses field does the same thing, so it's not creating a new issue. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an inconsistency because we were hardcoding the max lengths for name and description, while the meditor was pulling them from the schema. This PR updates the create dandiset page to pull these values from the schema as well.
Fixes #1474