Optimize Dandiset List Endpoint #1503

jjnesbitt · 2023-02-24T19:54:09Z

This PR does a couple of things:

Updates the function for retrieving a version's root paths to use the path field, instead of a count of parent links
Updates the dandiset list endpoint to make use of already aggregated asset paths information, instead of summing and counting all assets in a version on every request.

dandiapi/api/views/dandiset.py

dandiapi/api/models/asset_paths.py

Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com>

dandibot · 2023-03-10T20:27:37Z

🚀 PR was released in v0.3.22 🚀

jjnesbitt force-pushed the optimize-dandiset-list branch from 98eb5fb to 085cfe6 Compare February 24, 2023 19:59

jjnesbitt requested review from danlamanna and mvandenburgh February 27, 2023 19:48

jjnesbitt added 2 commits February 27, 2023 14:58

Use asset paths instead of always aggregating in dandiset list

e5b4074

Use path field to get root asset paths

b67ba48

jjnesbitt force-pushed the optimize-dandiset-list branch from 085cfe6 to b67ba48 Compare February 27, 2023 19:58

mvandenburgh reviewed Feb 28, 2023

View reviewed changes

dandiapi/api/views/dandiset.py Outdated Show resolved Hide resolved

dandiapi/api/views/dandiset.py Show resolved Hide resolved

Remove iterator from versions queryset

75d3bea

mvandenburgh approved these changes Feb 28, 2023

View reviewed changes

dandiapi/api/models/asset_paths.py Outdated Show resolved Hide resolved

jjnesbitt and others added 2 commits March 1, 2023 11:38

Fix typo

467128d

Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com>

Merge branch 'master' into optimize-dandiset-list

549131d

jjnesbitt merged commit 6292ec9 into master Mar 1, 2023

jjnesbitt deleted the optimize-dandiset-list branch March 1, 2023 17:13

dandibot added the released This issue/pull request has been released. label Mar 10, 2023

Provide feedback