Only allow selecting one license on create dandiset page #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
added
patch
jjnesbitt
approved these changes
Feb 27, 2023
mvandenburgh
force-pushed
the
limit-to-one-license-create-dandiset-view
branch
from
98c3e7b
to
8df943d
Compare
mvandenburgh
force-pushed
the
limit-to-one-license-create-dandiset-view
branch
from
8df943d
to
7f2a040
Compare
|
🚀 PR was released in |
waxlamp
reviewed
Feb 27, 2023
| @@ -159,7 +158,14 @@ if (!loggedIn()) { | |||
| } | |||
|
|
|||
| async function registerDandiset() { | |||
| const metadata = { name: name.value, description: description.value, license: license.value }; | |||
| const metadata: Record<string, any> = { | |||
There was a problem hiding this comment.
Shouldn't this be Record<"name" | "description", string>?
There was a problem hiding this comment.
I'm guessing the reason this was done was to prevent the type checker from complaining when the license field is added below.
There was a problem hiding this comment.
Can you do
const metadata: {name: string, description: string, license?: LicenseType} = ...
🤷♂️
There was a problem hiding this comment.
Can you do
const metadata: {name: string, description: string, license?: LicenseType} = ...man_shrugging
Yeah, that syntax is much better. And my use of any here also inadvertently hid a bug 😞
I thought I tested it on the deploy preview and it worked, but clearly I messed something up
There was a problem hiding this comment.
Follow up on this - #1510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1476