Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to copy id to clipboard #1523

Merged
merged 8 commits into from
Mar 16, 2023
Merged

Add button to copy id to clipboard #1523

merged 8 commits into from
Mar 16, 2023

Conversation

marySalvi
Copy link
Contributor

@marySalvi marySalvi commented Mar 6, 2023

closes #1194
closes #1525
closes #1451

Adds the ability to copy the ID to clipboard

image

@satra
Copy link
Member

satra commented Mar 6, 2023

it would be nice if this would copy the dandi accession id for draft dandisets, but DOIs for published dandisets.

@jjnesbitt
Copy link
Member

it would be nice if this would copy the dandi accession id for draft dandisets, but DOIs for published dandisets.

I'd think in that case we should add the DOI as a first hand field on the DLP, with a copy button.

@waxlamp
Copy link
Member

waxlamp commented Mar 7, 2023

it would be nice if this would copy the dandi accession id for draft dandisets, but DOIs for published dandisets.

I'd think in that case we should add the DOI as a first hand field on the DLP, with a copy button.

Seconded. I have opened #1525 to track this separately.

@marySalvi marySalvi requested a review from jjnesbitt March 7, 2023 21:27
@marySalvi
Copy link
Contributor Author

I decided to combine these three issues, #1194 #1525 and #1451, into 1 pr because they are so similar.

@satra
Copy link
Member

satra commented Mar 14, 2023

thank you @marySalvi - for the published dandiset, the id should include the version (so DANDI:<dandiset id>/<version> see the id tag over here: https://api.dandiarchive.org/api/dandisets/000402/versions/0.230307.2132/

@marySalvi
Copy link
Contributor Author

thank you @marySalvi - for the published dandiset, the id should include the version (so DANDI:<dandiset id>/<version> see the id tag over here: https://api.dandiarchive.org/api/dandisets/000402/versions/0.230307.2132/

Thank you for the clarification. I'll update.

Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, one suggestion about the copy function logic

web/src/views/DandisetLandingView/DandisetMain.vue Outdated Show resolved Hide resolved
@marySalvi marySalvi merged commit 2ab2f20 into master Mar 16, 2023
@marySalvi marySalvi deleted the issue-1194 branch March 16, 2023 17:41
@dandibot
Copy link
Member

🚀 PR was released in v0.3.26 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a button to copy dandiset DOI make doi clear on a published DLP add copy button for id
6 participants