Add doi share link and update styles #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satra
reviewed
Mar 16, 2023
| @@ -104,11 +118,12 @@ export default defineComponent({ | |||
| } | |||
| return ''; | |||
| }); | |||
| const doiLink = computed(() => (meta.value?.doi ? `https://doi.org/:${meta.value?.doi}` : '')); | |||
There was a problem hiding this comment.
extra : snuck in. otherwise the output looks great.
Suggested change
| const doiLink = computed(() => (meta.value?.doi ? `https://doi.org/:${meta.value?.doi}` : '')); | |
| const doiLink = computed(() => (meta.value?.doi ? `https://doi.org/${meta.value?.doi}` : '')); |
mvandenburgh
approved these changes
Mar 21, 2023
marySalvi
added
release
Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com>
mvandenburgh
approved these changes
Mar 21, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #712
Adds DOI link to share modal:
