Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for asset metadata re-extraction #1545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjnesbitt
Copy link
Member

Closes #1450
Closes #1118

@yarikoptic
Copy link
Member

What's your plan @AlmightyYakob here - wasn't it close to completion?

@jjnesbitt
Copy link
Member Author

What's your plan @AlmightyYakob here - wasn't it close to completion?

I unfortunately fell behind on this, as other things took priority. There are still logistical issues to work out on this PR, and at the moment my current priority is the embargo re-design. After that, I could take another pass at this.

@yarikoptic
Copy link
Member

this might be relevant in the scope/to address

my current priority is the embargo re-design. After that, I could take another pass at this.

embargo is a curse! ;) we should see how to move this from the stalled point. attn @waxlamp

@yarikoptic
Copy link
Member

in principle even

is related here since we might want to redo extraction upon dandischema upgrade.

@jjnesbitt do you have plans to get back to this PR?

@jjnesbitt jjnesbitt force-pushed the asset-metadata-extraction branch 5 times, most recently from 5c04aa2 to 639b8bc Compare September 24, 2024 18:11
@jjnesbitt jjnesbitt marked this pull request as ready for review September 24, 2024 18:21
@jjnesbitt
Copy link
Member Author

I believe this is ready to go. @jwodder or @yarikoptic can you verify that the nwb2asset function is being used correctly? As far as I'm aware from local testing it seems to be working correctly, but I don't exactly have a very good example asset to test the before and after. If you have a good example asset for this, that would also be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updating metadata on all draft assets Add a mechanism to recompute asset metadata for uploaded assets
2 participants