Avoid clobbering version metadata when calculating assets summary

[danlamanna]

Changes to version metadata that came in while version_aggregate_assets_summary is running can be overwritten. This change will only update the assetsSummary if the metadata is the same at save time, otherwise, it's a noop and the summary aggregation is retried.

[danlamanna]

This is dependent on #1638.

[yarikoptic]

#1638 was merged in July. If this PR is still pertinent -- please re-base/resolve conflicts @danlamanna

[waxlamp]

This was approved but never merged. Was there something blocking it, @danlamanna?

Additionally, it's now out of date, so if this is still a valid thing to merge (I believe it is) let's get it in shape to merge. @danlamanna do you want to do that yourself, or can you delegate to someone else?

There's some outstanding issues with this PR (will expand on this in a comment)

[danlamanna]

This was approved but never merged. Was there something blocking it, @danlamanna?

Additionally, it's now out of date, so if this is still a valid thing to merge (I believe it is) let's get it in shape to merge. @danlamanna do you want to do that yourself, or can you delegate to someone else?

I had thought this was replacing a Version.save with a Version.update, but it's not. So it's still "broken" in the sense that we're missing the hooks called in .save, but it fixes the potential data loss bug with version changes occurring simultaneously with aggregate summaries, so we should merge it.

@mvandenburgh Did you see something else wrong with it?

[mvandenburgh]

This was approved but never merged. Was there something blocking it, @danlamanna?
Additionally, it's now out of date, so if this is still a valid thing to merge (I believe it is) let's get it in shape to merge. @danlamanna do you want to do that yourself, or can you delegate to someone else?

I had thought this was replacing a Version.save with a Version.update, but it's not. So it's still "broken" in the sense that we're missing the hooks called in .save, but it fixes the potential data loss bug with version changes occurring simultaneously with aggregate summaries, so we should merge it.

@mvandenburgh Did you see something else wrong with it?

Oh, i thought the same thing 🤦

No, I agree this should be merged

[dandibot]

🚀 PR was released in v0.3.67 🚀