Render description field as markdown #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewers, here's what I'm looking for from each of you:
Thanks all! |
jjnesbitt
approved these changes
Apr 10, 2023
danlamanna
approved these changes
Apr 10, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the use of marked and DOMPurify to treat the description metadata field as a Markdown document.
The background here is that we'd like a way to give a bit more control to end users over the formatting of their Dandiset descriptions so they can put, e.g., "release notes" here to let consumers of their data know why they published a new version. The fuller solution for this is tracked in #189, but this feature allows a minor form of that ability in addition to its value in itself.
Closes #1567.