Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VJSF/ajv dependencies, refactor VJSF component to use <script setup> #1599

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Update VJSF/ajv dependencies, refactor VJSF component to use <script setup> #1599

merged 4 commits into from
Jun 26, 2023

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh mvandenburgh commented May 22, 2023 •
edited
Loading

Some preliminary updates before I investigate integrating AJV with VJSF.

Also fixes #1384 (See comment below)

@mvandenburgh
Copy link
Member Author

Updating VJSF also has the side effect of fixing #1384, now that koumoul-dev/vuetify-jsonschema-form#411 is merged and released.

@mvandenburgh mvandenburgh added patch Increment the patch version when merged release Create a release when this pr is merged labels May 22, 2023
@mvandenburgh mvandenburgh changed the title Update VJSF/ajv dependencies, VJSF component syntax Update VJSF/ajv dependencies, refactor VJSF component to use <script setup> Jun 26, 2023
jjnesbitt
jjnesbitt approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing I'd request (very minor I know) is that d01bc4b be fixed-up into 284374c, since it's just a formatting fix, and we don't squash our commits on merge to master.

If you do that, it will probably dismiss this approval, so just re-request and I'll approve it.

@mvandenburgh mvandenburgh merged commit b8459a1 into master Jun 26, 2023
2 checks passed
@mvandenburgh mvandenburgh deleted the vjsf-updates branch June 26, 2023 21:47
@dandibot
Copy link
Member

🚀 PR was released in v0.3.45 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnesbitt jjnesbitt jjnesbitt approved these changes

@waxlamp waxlamp Awaiting requested review from waxlamp

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metadata editor: Contributor: URL
3 participants
@mvandenburgh @dandibot @jjnesbitt