Fix user approval workflow #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to fix a bug in which a user is first rejected, then later approved. In that use case, the user's active flag remains `False` from the rejection and is never set to `True` during the subsequent approval.
mvandenburgh
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
LGTM. I noticed some other issues with this endpoint that may also be causing problems - they are likely out of scope for this PR so I filed an issue #1623
|
is there any way to figure out all possibly effected users since may be there were some others who just gave up and didn't complain last the last one? |
Yes, it appears there are some other users in this situation - I'll share them privately |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user approval form handler was relying on "active" being the default state for a Django user, and therefore users who were approved after being rejected retained their "inactive" status. This PR fixes that by explicitly setting users to active whenever they are approved.
Closes #1619.