Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding neurosift to external services #1647

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Adding neurosift to external services #1647

merged 2 commits into from
Jul 13, 2023

Conversation

satra
Copy link
Member

@satra satra commented Jul 6, 2023

closes #1646

@magland
Copy link
Contributor

magland commented Jul 7, 2023

As mentioned in #1646 "scratchrealm" needs to be replaced by "flatironinstitute", and the links won't actually work until tomorrow.

@yarikoptic
Copy link
Member

I have looked at https://deploy-preview-1647--gui-staging-dandiarchive-org.netlify.app/dandiset/200560/draft/files?location=sub-foo and it seems to work :
image
although I am not sure I am yet grasping what it shows, e.g. what is the subject id? whenever metacell after what feels 100x time of that shows the value to be there:
image

@magland
Copy link
Contributor

magland commented Jul 8, 2023

@yarikoptic I have hard-coded the meta information displayed on the left based on a couple nwb files I have tested with. Evidently there are fields that are not being included. I'll open an issue on neurosift.

Also, this example doesn't showcase the visualizations, because the file doesn't have acquisitions data. The capabilities will expand over time.

@waxlamp
Copy link
Member

waxlamp commented Jul 13, 2023

@satra, I'll leave it to you to merge this if/when you believe it's ready. I'm not doing it myself because I'm not sure if we're waiting on updates to Neurosift before we push this integration live.

@satra
Copy link
Member Author

satra commented Jul 13, 2023

i'm going to merge this and then do a separate PR to indicate what kind of url to provide the service.

@satra satra merged commit 4b937b5 into master Jul 13, 2023
@satra satra deleted the enh/add-neurosift branch July 13, 2023 17:41
@dandibot
Copy link
Member

🚀 PR was released in v0.3.46 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: visualize NWB files with neurosift
5 participants