Use correct asset download URL for external services #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
force-pushed
the
embargoed-asset-external-link
branch
from
8f6c645
to
d9b9283
Compare
jjnesbitt
requested changes
Oct 2, 2023
|
what is "correct" in the context of a URL? |
Co-authored-by: Jacob Nesbitt <jjnesbitt2@gmail.com>
I updated the description to answer this question in better detail (I should have done that upon marking this PR as ready for review--sorry!). |
jjnesbitt
approved these changes
Oct 4, 2023
|
I noticed this PR has been approved. Do you have an estimate for when it will be deployed? Thanks |
waxlamp
added
patch
|
🚀 PR was released in |
@magland, I just merged this PR and it is deploying as we speak! Please check in a little while to see if the new feature is working as intended, and follow up here if there are any lingering problems. |
|
@waxlamp it's working, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an external service is called from the file browser, the asset URL used is always the S3 URL, even in the case of an owner browsing an embargoed Dandiset. In the latter case, the S3 URL, which is not presigned, does not allow general access to the asset, causing the external service to fail when it tries to retrieve the data.
This PR modifies the generation of that asset URL to emit the S3 URL for open Dandiset assets, and the internal DANDI API asset URL (which redirects to the correct presigned S3 URL) for embargoed Dandiset assets. (Note that the target external service must still authenticate to the DANDI server in order for this redirection to succeed; that in turn requires a design that supports using DANDI API keys, etc.)