Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File page index fix #1704

Merged
merged 4 commits into from
Oct 17, 2023
Merged

File page index fix #1704

merged 4 commits into from
Oct 17, 2023

Conversation

marySalvi
Copy link
Contributor

Closes #1677
This PR adds the page index value to the route query.
Please also note that I removed a few watch statements in favor of reactive values as the watch statements were causing multiple calls with the added query value. I think its generally good practice to avoid watches when possible.

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marySalvi it seems this doesn't work if you try to navigate directly to a page, i.e. clicking on https://deploy-preview-1704--gui-staging-dandiarchive-org.netlify.app/dandiset/209782/draft/files?location=sub-CRS2&page=3 brings me to page 1, even though the URL specifies page 3.

web/src/views/FileBrowserView/FileBrowser.vue Outdated Show resolved Hide resolved
@marySalvi
Copy link
Contributor Author

@marySalvi it seems this doesn't work if you try to navigate directly to a page, i.e. clicking on https://deploy-preview-1704--gui-staging-dandiarchive-org.netlify.app/dandiset/209782/draft/files?location=sub-CRS2&page=3 brings me to page 1, even though the URL specifies page 3.

Good catch. It is actually the 3rd page of results its just that pagination text field isn't updated correctly. I'll fix that.

@marySalvi
Copy link
Contributor Author

@marySalvi it seems this doesn't work if you try to navigate directly to a page, i.e. clicking on https://deploy-preview-1704--gui-staging-dandiarchive-org.netlify.app/dandiset/209782/draft/files?location=sub-CRS2&page=3 brings me to page 1, even though the URL specifies page 3.

Good catch. It is actually the 3rd page of results its just that pagination text field isn't updated correctly. I'll fix that.

fixed in 6e78153

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marySalvi marySalvi merged commit f9e83f4 into master Oct 17, 2023
3 checks passed
@marySalvi marySalvi deleted the file-page-index-fix branch October 17, 2023 15:55
@dandibot
Copy link
Member

🚀 PR was released in v0.3.58 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getting urls to specific pages
3 participants