-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File page index fix #1704
File page index fix #1704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marySalvi it seems this doesn't work if you try to navigate directly to a page, i.e. clicking on https://deploy-preview-1704--gui-staging-dandiarchive-org.netlify.app/dandiset/209782/draft/files?location=sub-CRS2&page=3 brings me to page 1, even though the URL specifies page 3.
Good catch. It is actually the 3rd page of results its just that pagination text field isn't updated correctly. I'll fix that. |
fixed in 6e78153 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🚀 PR was released in |
Closes #1677
This PR adds the page index value to the route query.
Please also note that I removed a few watch statements in favor of reactive values as the watch statements were causing multiple calls with the added query value. I think its generally good practice to avoid watches when possible.