Remove pinning on django-storages[boto3] #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
approved these changes
Oct 17, 2023
|
While everything here seems to make sense, have you been able to properly test it? Since locally it wouldn't actually change anything, correct? |
Right. I'll make sure to do a test upload in staging once this is deployed there. |
The bug that mandated pinning this dependency has been fixed in the latest release.
mvandenburgh
force-pushed
the
update-django-storages-boto3
branch
from
847c9e4
to
365e1f3
Compare
|
(just rebasing so the dandi-cli tests pass) |
|
I uploaded some assets to staging using the CLI after deploying this and everything appears to work fine, so this should be fine to deploy to production the next time we cut a release. |
|
🚀 PR was released in |
brianhelba
added a commit
that referenced
this pull request
Nov 3, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 3, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 3, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 3, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 3, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 3, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 3, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 6, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 6, 2023
This completes #1717, to use the latest django-storages version.
brianhelba
added a commit
that referenced
this pull request
Nov 6, 2023
This completes #1717, to use the latest django-storages version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug that mandated pinning this dependency (#1691) has been fixed in the latest release of
django-storages(here's the changelog entry), so we can remove the pinning.Additionally, the latest minor release of
django-storagesalso deprecatesstorages.backends.s3boto3.S3Boto3Storagein favor ofstorages.backends.s3.S3Storage, as well as changes the install extra from[boto3]to[s3], (changelog entry), so I went ahead and made those changes here as well.