Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.11 #1736

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Require Python 3.11 #1736

merged 2 commits into from
Nov 6, 2023

Conversation

brianhelba
Copy link
Collaborator

No description provided.

@mvandenburgh
Copy link
Member

Thanks @brianhelba. I made an attempt to go to 3.12 here #1719, but it seems like the removal of distutils (among other things) makes that not as easy.

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I don't think the --keep-runtime-typing to pyupgrade does anything on 3.11. The pyupgrade docs aren't really clear on the exact functionality of it, but Ruff also implements that rule and has an explanation in its docs for it.

@brianhelba
Copy link
Collaborator Author

FYI I don't think the --keep-runtime-typing to pyupgrade does anything on 3.11. The pyupgrade docs aren't really clear on the exact functionality of it, but Ruff also implements that rule and has an explanation in its docs for it.

Yeah, good point. Thanks for the tip.

@brianhelba brianhelba merged commit ec0c1f1 into master Nov 6, 2023
10 checks passed
@brianhelba brianhelba deleted the py311 branch November 6, 2023 21:05
@dandibot
Copy link
Member

dandibot commented Nov 7, 2023

🚀 PR was released in v0.3.60 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants