Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S113 Probable use of requests call without timeout #1751

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix S113 Probable use of requests call without timeout #1751

merged 1 commit into from
Nov 29, 2023

Conversation

brianhelba
Copy link
Collaborator

No description provided.

@brianhelba
Copy link
Collaborator Author

This may not capture all use of requests, but it's at least an improvement.

yarikoptic
yarikoptic reviewed Nov 17, 2023
View reviewed changes
dandiapi/api/doi.py Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Member

FTR similar pr in client: dandi/dandi-cli#1369

@brianhelba brianhelba merged commit 8bd133b into master Nov 29, 2023
10 checks passed
@brianhelba brianhelba deleted the requests-timeout branch November 29, 2023 21:00
@dandibot
Copy link
Member

dandibot commented Dec 1, 2023

🚀 PR was released in v0.3.66 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianhelba @yarikoptic @dandibot @mvandenburgh