Fix RET505 Unnecessary else / elif after return statement
#1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
reviewed
Nov 16, 2023
| return self.embargoed_blob.size | ||
| else: | ||
| return self.zarr.size | ||
| return self.zarr.size |
There was a problem hiding this comment.
I think this is a good example of this rule being kind of bad 🤷♂️.
There was a problem hiding this comment.
I think overall the design pattern above is suboptimal regardless of the diff which is overall "potato vs potato" to me. Neither original nor new code is provisioning to have some case which is no longer fulfilling the design (e.g. when new types of assets would be added...). Should have been likely a sequence of if/elif/else: raise AssertionError(f"Do not know how to get size for the {self}").
|
I support this rule and would be happy to have this merged. I think 99% of the time this vastly improves readability, and in the other 1% you can disable the rule. |
brianhelba
changed the title
else / `elif after return statementelse / elif after return statement
brianhelba
force-pushed
the
else-return
branch
3 times, most recently
from
7601ff0
to
e9c2f46
Compare
jjnesbitt
approved these changes
Dec 1, 2023
brianhelba
force-pushed
the
else-return
branch
from
e9c2f46
to
18a344d
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I like this rule or not. Most of the time, I think it probably is the right thing for readability, but sometimes it seems worse. Maybe I'm just not used to it?