Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 401 on unauthenticated embargo dandiset list #1790

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Return 401 on unauthenticated embargo dandiset list #1790

merged 1 commit into from
Jan 3, 2024

Conversation

jjnesbitt
Copy link
Member

Fixes #1788

This slightly changes the way the API behaves, aside from the stated goal. Previously, we defaulted to a value of true when embargoed was not specified. This PR changes that default to false, as otherwise, any un-authenticated users would need to always explicitly pass embargoed=false when calling the dandiset list endpoint.

cc @yarikoptic

@jjnesbitt jjnesbitt requested review from mvandenburgh and removed request for mvandenburgh December 14, 2023 22:38
@jjnesbitt jjnesbitt marked this pull request as draft December 14, 2023 23:24
@waxlamp waxlamp mentioned this pull request Dec 20, 2023
Closed
@waxlamp waxlamp removed their assignment Dec 21, 2023
@jwodder jwodder mentioned this pull request Dec 21, 2023
Closed
@yarikoptic yarikoptic mentioned this pull request Dec 21, 2023
Open
@jjnesbitt jjnesbitt marked this pull request as ready for review December 28, 2023 19:20
@jjnesbitt
Copy link
Member Author

I'll be including the appropriate webui changes in this PR as well, so that everything is consistent.

It turns out no webui changes are necessary, as embargoed=true isn't included in the UI unless the user is already logged in.

jwodder added a commit to dandi/backups2datalad that referenced this pull request Jan 2, 2024
@jwodder
Set embargoed=true when listing Dandisets from the Archive
a12eba0 
In preparation for dandi/dandi-archive#1790
@jjnesbitt jjnesbitt added release Create a release when this pr is merged patch Increment the patch version when merged labels Jan 3, 2024
@jjnesbitt jjnesbitt merged commit 73d1139 into master Jan 3, 2024
10 checks passed
@jjnesbitt jjnesbitt deleted the 1788-embargoed-dandiset-list branch January 3, 2024 21:29
@dandibot
Copy link
Member

dandibot commented Jan 3, 2024

🚀 PR was released in v0.3.70 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jan 3, 2024
jwodder added a commit to dandi/backups2datalad that referenced this pull request Jan 4, 2024
@jwodder
Set embargoed=true when listing Dandisets from the Archive
117ac8a 
In preparation for dandi/dandi-archive#1790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

@waxlamp waxlamp waxlamp approved these changes

@mvandenburgh mvandenburgh Awaiting requested review from mvandenburgh

Assignees

@jjnesbitt jjnesbitt

Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
DANDI Initiatives
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API should respond with 401 not just silently not list embargoed if embargoed are requested
4 participants
@jjnesbitt @dandibot @yarikoptic @waxlamp