Draft: Resolve all asset types being evaluated during upload validation #1818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to /linc-archive/pull/34 and #1814
During validation of
zarr
based orembargoed
datasets, a validation check occurs on theassetSummary
field in thedandiset.yaml
Prior to this PR, the only "assets" evaluated were "blob". In the query that is updated in this PR, the checks for
size
are expanded to not justblob
but other "asset" types within the Asset model -- see link below:dandi-archive/dandiapi/api/models/asset.py
Lines 137 to 145 in 1be249a
Prior to the fix in this PR, the following validation would fail on assets in
dandischema
such aszarr
: https://github.com/dandi/dandi-schema/blob/bdb7dd681435f1092814041eb01eb4fabe87bf57/dandischema/models.py#L1497