Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost dandischema to 0.9.* series so we get support for pydantic 2.0 and schema 0.6.5 #1823

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Boost dandischema to 0.9.* series so we get support for pydantic 2.0 and schema 0.6.5 #1823

merged 7 commits into from
Feb 21, 2024

Commits on Feb 21, 2024

  1. Boost dandischema to 0.9.* series so we get support for pydantic 2.0 … 

    …and schema 0.6.5
    @yarikoptic @mvandenburgh
    yarikoptic authored and mvandenburgh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a069b18 View commit details
    Browse the repository at this point in the history

  2. Adjust to new error msg in test_validate_version_metadata_no_assets 

     The validator for the `assetsSummary` field in the
 `PublishedDandiset` model in dandischema 0.9.0
 generates an error with a slightly different message
    @candleindark @mvandenburgh
    candleindark authored and mvandenburgh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    abfaec7 View commit details
    Browse the repository at this point in the history

  3. Adjust to new error msg in test_validate_asset_metadata_no_digest 

     The validator for the `digest` field in the
 `PublishedAsset` model in dandischema 0.9.0
 generates an error with a slightly different message
 than before
    @candleindark @mvandenburgh
    candleindark authored and mvandenburgh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    117d73d View commit details
    Browse the repository at this point in the history

  4. Replace use of deprecated methods from Dandiset in dandi-schema p… 

    …ackage
    @candleindark @mvandenburgh
    candleindark authored and mvandenburgh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    881d03f View commit details
    Browse the repository at this point in the history

  5. Format with ruff

    @candleindark @mvandenburgh
    candleindark authored and mvandenburgh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    172c2c5 View commit details
    Browse the repository at this point in the history

  6. Update definitions to $defs 

    This seems to be a breaking change in pydantics json schema export function.
    @mvandenburgh
    mvandenburgh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b22308e View commit details
    Browse the repository at this point in the history

  7. Fix "Schema Key" becoming an entry in the meditor 

    Pydantic 2.0's JSON schema export no longer specifies a `type` field for
the `schemaKey` property, and leaves it undefined instead. This change
makes it so an undefined type also delegates it as a "basic schema",
meaning it will not be rendered as its own tab in the meditor.
    @mvandenburgh
    mvandenburgh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    dd2c7b3 View commit details
    Browse the repository at this point in the history