Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete/not-applicable TODO #1829

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

yarikoptic
Copy link
Member

The comment used to correspond to reality, and was needed for some ad-hoc manual invocation to setTokenHack but it was removed in 984451c AKA v0.1.37~27^2~9^2~79^2
a few years ago. Now this is the correct specification of DRF

The comment used to correspond to reality, and was needed for some ad-hoc
manual invocation to setTokenHack but it was removed in
984451c
AKA v0.1.37~27^2~9^2~79^2
a few years ago.  Now this is the correct specification of DRF
@yarikoptic
Copy link
Member Author

ping @waxlamp -- this might be trivial while the memory is fresh on that WWW-Authenticate investigation... please review/merge

Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO does seem to be out of date. No one on the engineering team knows what the "setTokenHack login workaround" is, and in fact using DRF's token authentication is the right way to be doing this.

@waxlamp waxlamp merged commit 47c6f75 into dandi:master Feb 13, 2024
10 checks passed
@dandibot
Copy link
Member

🚀 PR was released in v0.3.76 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 14, 2024
@yarikoptic yarikoptic deleted the rm-TODO branch July 15, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants