Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open asset on click #1847

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Open asset on click #1847

merged 3 commits into from
Feb 9, 2024

Conversation

waxlamp
Copy link
Member

@waxlamp waxlamp commented Jan 31, 2024 •
edited
Loading

This splits out a contribution from #1666 that initiates the "view in app" action when the item itself is clicked.

Depends on #1846.

Closes #761.

(attn: @magland)

@waxlamp waxlamp mentioned this pull request Jan 31, 2024
Closed
marySalvi
marySalvi previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment to address but otherwise approved.

web/src/views/FileBrowserView/FileBrowser.vue Outdated Show resolved Hide resolved
@waxlamp
Process item click as "open item in browser"
15b9f33
@waxlamp
Prevent clicks on disabled dropdown from going to item
9d972da 
Without this, clicking on the disabled menu causes the `openItem(...)`
logic to execute, which is not what we want.
@waxlamp
Extend tooltip to educate about clicking on the item
c127907
@waxlamp waxlamp dismissed marySalvi’s stale review February 8, 2024 16:53

Need a new review on subsequent changes

yarikoptic
yarikoptic approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as desired. Thanks!

@waxlamp waxlamp changed the base branch from master to improve-action-icons February 9, 2024 15:56
Base automatically changed from improve-action-icons to master February 9, 2024 15:57
@waxlamp waxlamp added patch Increment the patch version when merged release Create a release when this pr is merged labels Feb 9, 2024
@waxlamp waxlamp merged commit cdb7327 into master Feb 9, 2024
3 checks passed
@waxlamp waxlamp deleted the open-on-click branch February 9, 2024 15:58
@dandibot
Copy link
Member

dandibot commented Feb 9, 2024

🚀 PR was released in v0.3.75 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 9, 2024
@satra satra mentioned this pull request Feb 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magland magland magland left review comments

@yarikoptic yarikoptic yarikoptic approved these changes

@marySalvi marySalvi marySalvi approved these changes

@mvandenburgh mvandenburgh Awaiting requested review from mvandenburgh

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clicking on NWB file in data viewer does nothing
5 participants
@waxlamp @dandibot @yarikoptic @magland @marySalvi