Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #1854

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Fix lint errors #1854

merged 3 commits into from
Feb 7, 2024

Conversation

waxlamp
Copy link
Member

@waxlamp waxlamp commented Feb 2, 2024

I noticed a few linting errors popping up in CI. This PR fixes them, in three bits:

  1. Update pyproject.toml to use the correct ruff config section names.
  2. Eliminate some explicit dictionary key checks in favor of dict.get().
  3. Use logging.getLogger() in place of directly instantiating a Logger object.

I believe (1) and (2) are fine (though I'd appreciate validation); (3) might be trickier: although the change I made is a best practice (even recommended directly by the docs for the logging module), it does represent a semantic change in the codebase.

Let me know if I should peel off one or more of these commits into separate PRs--glad to do so if it makes reviewing/merging easier.

@yarikoptic
Copy link
Member

could this be reviewed/merged asap so nobody wastes time chasing those CI fails?

@waxlamp waxlamp merged commit 54a67fe into master Feb 7, 2024
10 checks passed
@waxlamp waxlamp deleted the fix-lint-errors branch February 7, 2024 16:01
@dandibot
Copy link
Member

dandibot commented Feb 9, 2024

🚀 PR was released in v0.3.75 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants