Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build project with build & pyproject.toml #1855

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Build project with build & pyproject.toml #1855

merged 1 commit into from
Feb 7, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 6, 2024

dandi-archive is currently building its tarballs via python setup.py, which is deprecated and which is not the currently supported way to build with the setuptools_scm build-time requirement (used for storing the Git tag in the project version).

Indeed, the latest "Deploy backend to production run" has the following in the logs for the "Build app into tarball" step:

/usr/lib/python3/dist-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
  warnings.warn(
/home/runner/work/dandi-archive/dandi-archive/.eggs/setuptools_scm-8.0.4-py3.10.egg/setuptools_scm/_integration/setuptools.py:30: RuntimeWarning: 
ERROR: setuptools==59.6.0 is used in combination with setuptools_scm>=8.x

Your build configuration is incomplete and previously worked by accident!
setuptools_scm requires setuptools>=61

Suggested workaround if applicable:
 - migrating from the deprecated setup_requires mechanism to pep517/518
   and using a pyproject.toml to declare build dependencies
   which are reliably pre-installed before running the build tools

@waxlamp waxlamp merged commit cb5731f into master Feb 7, 2024
10 checks passed
@waxlamp waxlamp deleted the no-setup-py branch February 7, 2024 17:19
@dandibot
Copy link
Member

dandibot commented Feb 9, 2024

🚀 PR was released in v0.3.75 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants