Add e2e test for meditor validation #1865
Conversation
mvandenburgh
changed the title
mvandenburgh
force-pushed
the
playwright-meditor-tests
branch
3 times, most recently
from
71035c7
to
8d4aa48
Compare
mvandenburgh
force-pushed
the
playwright-meditor-tests
branch
3 times, most recently
from
f5923ae
to
537af67
Compare
mvandenburgh
force-pushed
the
playwright-meditor-tests
branch
from
28f38da
to
58e1a41
Compare
mvandenburgh
changed the title
| /** | ||
| * Read environment variables from file. | ||
| * https://github.com/motdotla/dotenv | ||
| */ | ||
| // require('dotenv').config(); |
There was a problem hiding this comment.
Should we strike this code block?
| /* Reporter to use. See https://playwright.dev/docs/test-reporters */ | ||
| reporter: 'html', |
There was a problem hiding this comment.
I believe we should be using either list, line, dot, or github when process.env.CI is set (probably github, though the docs don't fully explain what output you get when using that reporter).
| /* Base URL to use in actions like `await page.goto('/')`. */ | ||
| // baseURL: 'http://127.0.0.1:3000', |
There was a problem hiding this comment.
We should remove this or set it to http://127.0.0.1:8085 (if that's what's actually needed here).
| /* Run your local dev server before starting the tests */ | ||
| // webServer: { | ||
| // command: 'npm run start', | ||
| // url: 'http://127.0.0.1:3000', | ||
| // reuseExistingServer: !process.env.CI, | ||
| // }, |
There was a problem hiding this comment.
Probably get rid of this since we use a custom setup to launch the server and client, etc.
| ).toBeVisible(); | ||
| }; | ||
|
|
||
| const allDandisets = [ |
There was a problem hiding this comment.
I'm assuming all these Dandisets' metadatas are loaded into the database at some point?
| await page.getByPlaceholder("Password").click(); | ||
| await page.getByPlaceholder("Password").fill("password"); | ||
| await page.getByRole("button", { name: "Sign In " }).click(); | ||
| await page.waitForLoadState("networkidle"); |
There was a problem hiding this comment.
This is cool! However, the docs state
'networkidle' - DISCOURAGED wait until there are no network connections for at least 500 ms. Don't use this method for testing, rely on web assertions to assess readiness instead.
What's our justification for ignoring their (strongly worded) recommendation?
| await page.getByLabel("Dandiset title").click(); | ||
| await page.keyboard.press("End"); | ||
| await page.keyboard.press("Space"); | ||
| await page.keyboard.press("Tab"); | ||
| await page.getByLabel("Dandiset title").click(); | ||
| await page.keyboard.press("End"); | ||
| await page.keyboard.press("Backspace"); | ||
| await page.keyboard.press("Tab"); |
| await page.getByLabel("Dandiset title").click(); | ||
| await page.keyboard.press("End"); | ||
| await page.keyboard.press("Space"); | ||
| await page.keyboard.press("Tab"); | ||
| await page.getByLabel("Dandiset title").click(); | ||
| await page.keyboard.press("End"); | ||
| await page.keyboard.press("Backspace"); | ||
| await page.keyboard.press("Tab"); | ||
| await page.locator(".v-card__actions > button").first().click(); | ||
| await page.waitForTimeout(3000); | ||
| await page.waitForLoadState("networkidle"); |
There was a problem hiding this comment.
This needs a comment to explain what it's doing.
| const validIcon = await page.locator(".v-card__actions > i"); | ||
| const iconClass = await validIcon.getAttribute("class"); | ||
|
|
||
| if (Object.keys(invalidDandisets).includes(dandisetId)) { |
There was a problem hiding this comment.
Can this just be Object.hasOwn(invalidDandisets, dandisetId)?
| "axios": "^1.6.7", | ||
| "lodash": "^4.17.21" |
|
🚀 PR was released in |
This adds a new playwright-based E2E test that loads all the current dandisets on dandiarchive.org into the test DB, opens the meditor for each of them, and ensures the validation status is as expected depending on the current state of the metadata.
This will help us be confident that the changes in #1823 don't break anything.