Change asset path collation to "C" #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
added
patch
mvandenburgh
approved these changes
Mar 7, 2024
Yes, both staging and prod. For good measure, I locally pulled the exact postgres version running in prod. I could reproduce the failed migration from #1885, and once changing the collation to |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1885
While the
C.utf8collation seemed to work locally and in CI, that collation doesn't seem to exist in the production database, and so that migration failed in production. However the basicCcollation is present across all of these environments (all postgres environments, detailed here) and as far as I can tell, seems to operate in largely the same way. If/when we upgrade our database version in heroku, we could perhaps change back toC.utf8, if it mattered.This fix modifies the last migration, since the deployment failed in staging/production. If I were to create a new migration, I believe it would again fail, since it would have to first apply the failing migration to reach the fix.