Optimize asset list endpoint #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Paginate and fetch IDs of desired assets first, before doing left joins * Remove duplicate queries as a result of class inheritance * Remove extra query in raise_if_unauthorized method
This test was fetching an unordered list and comparing it to an ordered list, resulting in inconsistent failures.
mvandenburgh
approved these changes
Mar 25, 2024
jjnesbitt
added
patch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1891
The existing asset list endpoint is inefficient with how it queries the database, resulting in unnecessarily long response times from that endpoint. This is improved in the following ways:
raise_if_unauthorizedmethodThe results of these improvements are shown below. Note that these are the times for the SQL queries themselves, not the overall page load, as that can be inflated by the amount of data returned, and isn't useful for this discussion.
A couple things to note going forward:
countquery (the query that returns the total number of hits from which you're returning a single page) is usually slower than the query of interest itself, which makes sense. We may want to rethink the structure of our API respones if further optimization is desired, as if we were to remove this count, we would see a pretty widespread 2x speedup.