Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neurosift external service for .nwb.lindi.json #1922

Merged
merged 1 commit into from
May 6, 2024
Merged

neurosift external service for .nwb.lindi.json #1922

merged 1 commit into from
May 6, 2024

Conversation

magland
Copy link
Contributor

@magland magland commented Apr 15, 2024

Provides a neurosift external service button for .nwb.lindi.json files.

Also changes https://flatironinstitute.github.io/neurosift -> https://neurosift.app (note that currently github io gets redirected, so both work right now)

Example on staging site:
https://gui-staging.dandiarchive.org/dandiset/213569/draft/files?location=000946%2Fsub-BH494&page=1

Link to LINDI project

See discussion here: NeurodataWithoutBorders/lindi#42

@yarikoptic
Copy link
Member

I am ok with this, although .nwb.lindi.json is not known to any standard yet. But this would let to test this functionality etc.

@yarikoptic yarikoptic requested a review from waxlamp April 19, 2024 01:39
@kabilar
Copy link
Member

kabilar commented Apr 22, 2024

I am also in favor of adding this external service. Jeremy gave a presentation on LINDI during the NWB Developer Days. Among other benefits, it allows for representing a HDF5 file as a Zarr archive. Perhaps we could add it to DANDI Staging so that Jeremy can continue his development and testing of LINDI?

@magland
Copy link
Contributor Author

magland commented Apr 24, 2024

Thanks @yarikoptic and @kabilar . Yeah, it would be nice to having this in place at least on staging during this prototyping phase.

@yarikoptic
Copy link
Member

@waxlamp we would need your blessing here.

@yarikoptic
Copy link
Member

ok, it is trivial, there were no concerns from @dandi/archive-maintainers , so I would like us to proceed on this one. As it is very unlikely to have negative effects on the rest of the dandi-archive , I will proceed with merge (without release for now).

@yarikoptic yarikoptic merged commit 421c180 into dandi:master May 6, 2024
4 checks passed
@magland
Copy link
Contributor Author

magland commented May 6, 2024

Thanks @yarikoptic !

@dandibot
Copy link
Member

dandibot commented Jun 3, 2024

🚀 PR was released in v0.3.85 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants