In 1.14.3 it became client_config and .config was announced deprecated #1946
Conversation
…d, caused it to become None and I believe that caused our tests to start failing etc
|
ok, trivial fix seems to be . Makes our CI green. I will merge in an hour or so unless some @dandi/archive-maintainers would stop me. I am not marking for release although it might be desired happen our released instance would get that module updated. |
| @@ -67,7 +67,7 @@ | |||
| # Production-only | |||
| 'django-composed-configuration[prod]>=0.23.0', | |||
| 'django-s3-file-field[s3]>=1.0.0', | |||
| 'django-storages[s3]>=1.14.2', | |||
| 'django-storages[s3]>=1.14.3', | |||
There was a problem hiding this comment.
Just to note for future reference - I think in this case, a better approach would have been to pin this to the older version, i.e.
'django-storages[s3]==1.14.2',. In cases where we're unsure about a dependancy upgrade, we usually do that and add a TODO comment to look into it in the future.
There was a problem hiding this comment.
yeah, i had it in mind too and agree it would have been safer, but given that we have already lots of things to be developed,
❯ git grep TODO | wc -l
69and looking at the django-storages code decided that it was safe enough.
|
🚀 PR was released in |
and caused .config to become None
and I believe that caused our tests to start failing etc
If tests succeed, Closes #1940