Only use custom pagination class for asset list endpoint #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This retains the behavior of using a custom pagination class for the asset list endpoint
jjnesbitt
force-pushed
the
fix-dandiset-pagination
branch
from
3fda94e
to
68904ee
Compare
waxlamp
approved these changes
May 30, 2024
This was referenced Jun 3, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1917
#1911 greedily implemented the custom pagination class (not including
countin every page of the paginated response) for every listing endpoint. In reality, the main target of that PR was the asset list endpoint. Since there are various places in the web client that assume the removedcountfield is present, this PR reverts the functionality for all list endpoints except for the asset list endpoint.