-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock dandisets during un-embargo #1957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good.
One note: I didn't realize that we prohibit publishing of embargoed Dandisets. I wonder if we should consider lifting that ban--I can see why it would be useful to be able to do so, though the wording we're using makes it confusing ("it's embargoed... how can I be publishing this?") when really "publish" mostly means to create an immutable snapshot.
I thought it was a hard requirement that published dandisets be open access, from more of a NIH policy standpoint. |
yes, embargoed dandisets should not receive a published doi. publishing is only for non-embargoed dandisets. in the future we may publish restricted dandisets, but we haven't implemented that yet. to speak about roni's point of freezing versions on embargoed data, that's a different feature which we don't have. we should discuss whether that feature should even exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, with one requested change: within the exception names (and elsewhere as appropriate), please change the "UnEmbargo" capitalization to "Unembargo" (the word is spelled "unembargo", as "one word" and no hyphens, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UnEmbargo
spelling within the exception classes should be shifted to Unembargo
.
13965e9
to
492b48c
Compare
🚀 PR was released in |
This change will help prevent race conditions that could arise if modifications are allowed while un-embargo is ongoing.