Automate dandiset unembargo #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
reviewed
Jul 3, 2024
danlamanna
reviewed
Jul 3, 2024
jjnesbitt
force-pushed
the
automated-unembargo
branch
from
5700a0c
to
7721459
Compare
jjnesbitt
force-pushed
the
automated-unembargo
branch
2 times, most recently
from
c4bde3b
to
8fefb57
Compare
jjnesbitt
force-pushed
the
automated-unembargo
branch
from
8fefb57
to
bc1be9b
Compare
mvandenburgh
requested changes
Jul 19, 2024
waxlamp
reviewed
Jul 19, 2024
dandiapi/api/mail.py
Outdated
Comment on lines
46
to
53
| def build_message( # noqa: PLR0913 | ||
| to: list[str], | ||
| subject: str, | ||
| message: str, | ||
| html_message: str | None = None, | ||
| cc: list[str] | None = None, | ||
| bcc: list[str] | None = None, | ||
| ): |
There was a problem hiding this comment.
I don't know if this PR is the place for it, but since you've altered this function already: I wonder if this function would be better off with keyword-only arguments. That would make the use of the function elsewhere much clearer at a glance.
There was a problem hiding this comment.
This method is honestly pretty superfluous, as it simply wraps the construction of a mail.EmailMultiAlternatives class instance. I think it'd be better to remove it entirely.
There was a problem hiding this comment.
I'll file an issue for this.
jjnesbitt
added
patch
mvandenburgh
approved these changes
Jul 22, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automates the new unembargo workflow introduced in #1890. Now, when a dandiset unembargo is kicked off from the API, the unembargo task will immediately be put on the worker queue. If that task fails, both the devs and dandiset owners will be notified through an email, as well as through sentry. There's no retrying implemented for the dandiset unembargo task, as my thinking is that retrying an unknown error would simply cause the error to fail further. Instead, I think we should simply investigate and directly resolve any errors we might find.
The only qualm I have with this at the moment is that I wasn't able to find a good way to test that the desired email is sent when the dandiset unembargo task fails. I can test this myself locally when running the application in dev mode, but doing so in a testing context has proved more difficult, as it seems that either theThis has been addressed.on_failurehook isn't called, or the custom Task class isn't used at all. @mvandenburgh @danlamanna if you have any ideas here I'd be interested.