Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin access to embargoed asset blobs #2004

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

jjnesbitt
Copy link
Member

Fixes #1996

I also included a slight formatting / structural change of the raise_if_unauthorized function, since there was several nested if statements with no else statements.

@yarikoptic
Copy link
Member

now that audit merged/deployed, @waxlamp and @jjnesbitt could you please review/merge this one so we could get get our backups2datalad perform nominally?

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjnesbitt jjnesbitt added patch Increment the patch version when merged release Create a release when this pr is merged labels Aug 15, 2024
@jjnesbitt jjnesbitt merged commit 4cebe93 into master Aug 16, 2024
11 checks passed
@jjnesbitt jjnesbitt deleted the embargoed-asset-admin-access branch August 16, 2024 18:14
@dandibot
Copy link
Member

🚀 PR was released in v0.3.94 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbidden access to admin user to an embargoed asset (dandiset overall ok)
4 participants