Respond with 409 when creating duplicate asset blobs #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
reviewed
Aug 20, 2024
danlamanna
force-pushed
the
1920-ignore-integrity-errors
branch
from
bbf4360
to
a826de0
Compare
danlamanna
force-pushed
the
1920-ignore-integrity-errors
branch
from
a826de0
to
ebf518d
Compare
jjnesbitt
reviewed
Aug 21, 2024
jjnesbitt
approved these changes
Aug 21, 2024
|
dandi-cli downstream tests pass, but I wonder if we necessarily test such invocation. @jwodder WDYT - would there be effect on the client ? |
|
@yarikoptic I don't think this is relevant to any CLI tests. |
danlamanna
force-pushed
the
1920-ignore-integrity-errors
branch
from
ebf518d
to
bae575d
Compare
mvandenburgh
approved these changes
Aug 26, 2024
|
@yarikoptic All set? |
|
I guess - testing in the wilderness would show ;-) |
danlamanna
added
patch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1920
The existing upload pathway has a race condition where a competing asset blob gets created after our check. The
select_for_updatedoesn't lock anything if it can't find any existing rows. Using get_or_create should handle this edge case. Even though we still need to handle these conditions, I'm curious why clients are concurrently uploading identical blobs 🤷♂️.I haven't tested this locally yet, but it's probably worth a sanity check already.