Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text from the Handbook to the rejected user email #2022

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

kabilar
Copy link
Member

@kabilar kabilar commented Sep 5, 2024

No description provided.

Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new text makes more sense after the rejection reason block. Then it's "you were denied; here's why; here's some helpful info as a call to action".

@kabilar
Copy link
Member Author

kabilar commented Sep 5, 2024

I think the new text makes more sense after the rejection reason block. Then it's "you were denied; here's why; here's some helpful info as a call to action".

Thanks @waxlamp. I was actually hoping that we don't use the rejection reason block often. This would limit the amount of manual work that Yarik has to do, and provide a standard response. The reason for denial would be that an academic email is not associated with the GitHub account. And if an admin wanted to provide further explanation, then the rejection reason block would be available.

@kabilar
Copy link
Member Author

kabilar commented Sep 5, 2024

I think the new text makes more sense after the rejection reason block. Then it's "you were denied; here's why; here's some helpful info as a call to action".

Thanks @waxlamp. I was actually hoping that we don't use the rejection reason block often. This would limit the amount of manual work that Yarik has to do, and provide a standard response. The reason for denial would be that an academic email is not associated with the GitHub account. And if an admin wanted to provide further explanation, then the rejection reason block would be available.

Agree that if we do use the rejection reason block, it makes more sense to be above the template text. So I have moved the block.

Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one suggestion to soften and clarify what to do without an academic email address, but otherwise this looks good.

dandiapi/api/templates/api/mail/rejected_user_message.txt Outdated Show resolved Hide resolved
Co-authored-by: Roni Choudhury <2903332+waxlamp@users.noreply.github.com>
@waxlamp waxlamp self-assigned this Sep 10, 2024
@kabilar
Copy link
Member Author

kabilar commented Sep 16, 2024

Hi @waxlamp, would you be able to deploy these changes this week? Thank you.

@waxlamp waxlamp added patch Increment the patch version when merged release Create a release when this pr is merged labels Sep 20, 2024
@waxlamp waxlamp merged commit 8e6c079 into dandi:master Sep 20, 2024
11 checks passed
@waxlamp
Copy link
Member

waxlamp commented Sep 20, 2024

Hi @waxlamp, would you be able to deploy these changes this week? Thank you.

Done!

@dandibot
Copy link
Member

🚀 PR was released in v0.3.100 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants