Remove Girder code from API #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@dandi/dandiarchive please let us know if anything else is needed for this to land |
|
@dchiquito is out today, but he's aware of the refactoring that needs to be done to excise Girder3 from the various codebases. It's up there on his list along with publish workflow. Please wait for his (and/or @AlmightyYakob's) review before merging. |
|
Are the migration scripts still needed? If not there's still girder specific code in the |
|
is this one superseded by #272 @dchiquito ? |
brianhelba
approved these changes
May 12, 2021
dchiquito
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Girder code in dandiapi appears to be unused, and it needs to be removed so that the Docker test setup in dandi-cli can get rid of the Girder containers.