Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add garbage collection design doc #560

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Add garbage collection design doc #560

merged 5 commits into from
Apr 28, 2022

Conversation

dchiquito
Copy link
Contributor

@dchiquito dchiquito commented Oct 11, 2021 •
edited
Loading

A design doc for garbage collection policies.

Fixes #523
Fixes #177

@dchiquito
Copy link
Contributor Author

The linting failure is because of a bug: gforcada/flake8-isort#103

@dchiquito dchiquito added the design-doc Involves creating or discussing a design document label Oct 12, 2021
waxlamp
waxlamp reviewed Oct 13, 2021
View reviewed changes
Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, just left a couple of questions.

Fleshing out some of the mentions (e.g., lifecycle rules) could be a good idea, but we can also decide on those things at implementation time, or defer further discussion to a future design doc.

doc/design/garbage-collection-1.md Show resolved Hide resolved
doc/design/garbage-collection-1.md Show resolved Hide resolved
doc/design/garbage-collection-1.md Show resolved Hide resolved
yarikoptic
yarikoptic reviewed Oct 13, 2021
View reviewed changes
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! seems to cover all aspects. Just to make sure -- we no longer have a separate table of "metadata blobs", right?
I left minor comments/questions.

doc/design/garbage-collection-1.md Outdated Show resolved Hide resolved
doc/design/garbage-collection-1.md Show resolved Hide resolved
doc/design/garbage-collection-1.md Show resolved Hide resolved
@dchiquito
Copy link
Contributor Author

@yarikoptic correct, no more separate metadata tables.

@waxlamp waxlamp mentioned this pull request Nov 1, 2021
Closed
@waxlamp waxlamp mentioned this pull request Dec 30, 2021
Open
@dchiquito dchiquito force-pushed the garbage-collection-design-doc branch from 79fe5b6 to 404aa18 Compare April 6, 2022 15:50
@dchiquito dchiquito merged commit 7ad3f9a into master Apr 28, 2022
@dchiquito dchiquito deleted the garbage-collection-design-doc branch April 28, 2022 15:03
@dandibot
Copy link
Member

🚀 PR was released in v0.2.18 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waxlamp waxlamp waxlamp left review comments

@satra satra Awaiting requested review from satra

@yarikoptic yarikoptic Awaiting requested review from yarikoptic

Assignees
No one assigned
Labels
design-doc Involves creating or discussing a design document released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Garbage collection Write a design doc for garbage collection
5 participants
@dchiquito @dandibot @yarikoptic @satra @waxlamp