adding license field to the create dandiset page

[djarecka]

Adding a new field - license to the create dandiset page as a mandatory field.

closes #747

this PR requires changes in Dandischema, this is WIP

[djarecka]

@dchiquito @mvandenburgh - I know I'm not doing this properly, I hardcoded the licenses we are using. I found license types in schema.js file, but not sure what is the best way to extract the information from there..

[satra]

we should discuss this a bit more in the context of not requiring license for embargoed dandisets. see: dandi/dandi-schema#115

[mvandenburgh]

@dchiquito @mvandenburgh - I know I'm not doing this properly, I hardcoded the licenses we are using. I found license types in schema.js file, but not sure what is the best way to extract the information from there..

Types are only used for type-checking and are evaluated at compile time and then discarded, so unfortunately there's no way to access the license types in schema.ts at runtime. But, you should be able to extract them from the schema like this -

const licenses: ComputedRef<LicenseType[]> = computed(() => store.state.dandiset.schema.definitions.LicenseType.enum);

[djarecka]

@mvandenburgh - thank you, will try!

[waxlamp]

@djarecka, I converted this to a draft PR since you are still working on it.

[netlify]

❌ Deploy Preview for gui-staging-dandiarchive-org failed.

🔨 Explore the source changes: 4497b4e

🔍 Inspect the deploy log: https://app.netlify.com/sites/gui-staging-dandiarchive-org/deploys/61fd883f36c872000828f173

[mvandenburgh]

What are your thoughts on using a v-select instead of v-combobox here? IMO the extra autocomplete features v-combobox provides just confuse things, since there's only two license types to choose from. Also, fwiw the meditor uses a v-select for licenses.

[djarecka]

sorry, I missed the comments.... I'm not sure if I had any specific thoughts, will try to use v-select

[djarecka]

@mvandenburgh - I came back to this old PR, I merged the current master, but have some errors, that I don't fully understand. Could you please help me with it

[mvandenburgh]

@djarecka See below suggestions, they should fix the type-checking errors. Let me know if you have any questions.

[mvandenburgh]

Suggested change

	const license = ref('');
	const license = ref<License>();

This is what is causing the type-check failures. license is implicitly defined as type Ref<string> here, but the schema dictates that it's an array of string literals, which is encapsulated in the License type.

Making this change will make license instead have a type of Ref<License | undefined>, which works as long as you also update saveDisabled to return true if the dandiset is not embargoed and has an undefined license (which we want to do anyways), i.e. add || (!embargoed.value && !license.value) to it (github code review unfortunately won't let me make that a formal suggestion b/c this PR doesn't modify that code yet).

[djarecka]

did you have in mind ref<LicenseType>()?

[mvandenburgh]

No, ref<License>() (you would also have to add that to the import statement). LicenseType refers to a string, while License is an array of LicenseTypes that is populated by the v-select (see schema.ts for those type definitions)

[djarecka]

@mvandenburgh - could you help me with the error, don't understand it

[mvandenburgh]

@djarecka I updated the tests as we discussed - this PR looks good to me after removing the redundant code I mentioned below.

[dandibot]

🚀 PR was released in v0.2.32 🚀