Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up pyppeteer e2e tests #990

Merged
merged 6 commits into from
Apr 6, 2022
Merged

Set up pyppeteer e2e tests #990

merged 6 commits into from
Apr 6, 2022

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh mvandenburgh commented Mar 29, 2022 •
edited
Loading

This PR

  • sets up girder-pytest-pyppeteer to be run locally through tox or in CI with GitHub Actions
  • converts two of the simpler puppeteer e2e tests to pyppeteer
    • I was thinking the remaining conversions could be done incrementally. This would ease review and also let us tackle these as time/cycles permit. In the meantime we can continue running the puppeteer-based tests in CI alongside the pyppeteer ones (which is exactly what I've set up in this PR). I've filed Port remaining jest/puppeteer tests to pyppeteer #995 for this.
  • Separate E2E tests into their own CI job
    • As part of this I've changed things so the E2E tests run for all changes, not just frontend changes. It's completely plausible for a backend-only change to break the frontend, which I must not have thought about when I set it up that way.

Closes #738.

@mvandenburgh mvandenburgh force-pushed the configure-girder-pytest-pyppeteer branch 14 times, most recently from 72026c4 to c47ab85 Compare March 31, 2022 19:38
@mvandenburgh mvandenburgh force-pushed the configure-girder-pytest-pyppeteer branch from c47ab85 to 6ba73de Compare March 31, 2022 20:33
@mvandenburgh mvandenburgh changed the title [wip] Set up pyppeteer e2e tests Set up pyppeteer e2e tests Mar 31, 2022
@mvandenburgh mvandenburgh marked this pull request as ready for review March 31, 2022 20:48
@mvandenburgh mvandenburgh force-pushed the configure-girder-pytest-pyppeteer branch from 6ba73de to 4624aac Compare March 31, 2022 20:50
dchiquito
dchiquito approved these changes Apr 6, 2022
View reviewed changes
dandiapi/api/tests/e2e/utils.py Outdated Show resolved Hide resolved
@mvandenburgh @dchiquito
Use . instead of text() for searching for text with XPaths
2154979 
Co-authored-by: Daniel Chiquito <daniel.chiquito@kitware.com>
@mvandenburgh mvandenburgh merged commit 0af22dd into master Apr 6, 2022
@mvandenburgh mvandenburgh deleted the configure-girder-pytest-pyppeteer branch April 6, 2022 21:38
@mvandenburgh mvandenburgh mentioned this pull request Apr 8, 2022
Merged
@dandibot
Copy link
Member

🚀 PR was released in v0.2.8 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchiquito dchiquito dchiquito approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E test overhaul to enable testing publish, file browser, etc
3 participants
@mvandenburgh @dandibot @dchiquito